get rid of github.com/gogo/protobuf #526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
github.com/gogo/protobuf is deprecated and doesn't work with newer protobuf files. It's time to switch to standard protobuf.
Detail
It's important that this change won't affect services that are using the old marshaled.
Unfortunately, gogo protobuf doesn't handle messages generated by newer protobuf (it even panics).
To allow simple migration, in the old marshaled, I added an optional fallback (enabled by default) to github.com/golang/protobuf/proto when gogo failed to marshal/unmarshal message.
Thanks to that, it's possible to create a two-step migration:
Checklist
The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:
make up
.make test_short
for a quick check.make test
.